Re: [PATCH 2/2] Fix t3404 assumption that `wc -l` does not use whitespace.
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Apr 27, 2008, 15:22 UTC
- Message-ID
- <alpine.DEB.1.00.0804271620440.16320@eeepc-johanness>
- In-Reply-To
- <20080427151610.GB57955@Hermes.local>
Hi,
On Sun, 27 Apr 2008, Brian Gernhardt wrote:
> Should this construct go into CodingStyle? I seem to have to write > patches like this every month or so.
Yes, probably. I am very sorry, I really should have reviewed those patches better (I know that ":" in expr is better than "match", "tac" is something to be avoided, and "wc -l" can output whitespace). It did not help that I hated the fact that that series changed the original design without even understanding it.
Ciao, Dscho