git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] Fix t3404 assumption that `wc -l` does not use whitespace.

From
Jeff King <peff@peff.net>
Date
Apr 28, 2008, 09:41 UTC
Message-ID
<20080428094119.GA20499@sigill.intra.peff.net>
In-Reply-To
<B287EA35-6C5D-4A5A-BEF1-C55A70D913ED@silverinsanity.com>
On Sun, Apr 27, 2008 at 11:32:24AM -0400, Brian Gernhardt wrote:
Show 9 quoted lines
> Eh, not everyone's perfect.  I would have used `rev` instead of `tac` and 
> still been wrong for Solaris.  But it seems that the `wc -l` whitespace 
> issue seems to hit nearly everyone at some point, so I thought it would be 
> a good candidate for CodingStyle.
>
> Personally, I'd love to have the time to review all the patches to catch 
> these issues while still on the list instead of waiting until they hit 
> next and I tried to compile it.  But I don't always notice, have time, or 
> care myself.

BTW, how did you discover this bug? Through normal use, or was there a failing test?

If a failing test, then I wonder if we could get a few people to set up automated tests on alternate platforms. IIRC, Junio makes sure that master always passes test on his Linux box and KO (Debian and Redhat, I think?). Other platforms could "git pull && make test" daily. I could probably do Solaris (once I get the tests to complete pass at all!) and FreeBSD 6.

-Peff
Previous: Brian GernhardtNext: Mike Ralphson
Message 4 of 23 in “Fix t3404 assumption that `wc -l` does not use whitespace.”
  1. 2/2 Fix t3404 assumption that `wc -l` does not use whitespace.Brian Gernhardt, Apr 27, 2008
  2. Johannes SchindelinApr 27, 2008
  3. Brian GernhardtApr 27, 2008
  4. Jeff KingApr 28, 2008
  5. Mike RalphsonApr 28, 2008
  6. Jeff KingMay 13, 2008
  7. Mike RalphsonMay 13, 2008
  8. Mike RalphsonMay 15, 2008
  9. Jeff KingMay 15, 2008
  10. Jeff KingMay 15, 2008
  11. Junio C HamanoMay 15, 2008
  12. Mike RalphsonMay 16, 2008
  13. Brian GernhardtApr 28, 2008
  14. Junio C HamanoApr 27, 2008
  15. Johannes SchindelinApr 28, 2008
  16. Jörg SommerApr 28, 2008
  17. Johannes SchindelinApr 28, 2008
  18. Jörg SommerApr 28, 2008
  19. Johannes SchindelinApr 28, 2008
  20. Junio C HamanoApr 28, 2008
  21. Johannes SchindelinApr 28, 2008
  22. Junio C HamanoApr 28, 2008
  23. Johannes SchindelinApr 28, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.