Re: [PATCH 2/2] Fix t3404 assumption that `wc -l` does not use whitespace.

From: Brian Gernhardt <benji@silverinsanity.com>
Date: Apr 28, 2008, 12:40 UTC
Message-ID: <8BF98729-6665-489A-A77B-59498B6C8C29@silverinsanity.com>
In-Reply-To: <20080428094119.GA20499@sigill.intra.peff.net>

On Apr 28, 2008, at 5:41 AM, Jeff King <peff@peff.net> wrote:

> BTW, how did you discover this bug? Through normal use, or was there a
> failing test?

My small series of one-line patches were from trying to get t3404 (IIRC) to work. So our tests do help. ;-)

Show 9 quoted lines

> If a failing test, then I wonder if we could get a few people to set  
> up
> automated tests on alternate platforms. IIRC, Junio makes sure that
> master always passes test on his Linux box and KO (Debian and  
> Redhat, I
> think?). Other platforms could "git pull && make test" daily. I could
> probably do Solaris (once I get the tests to complete pass at all!)  
> and
> FreeBSD 6.

I have a script that boils down to 'make && make test && make install'. I pull, check changes, and then run it once or twice a week. I can't dedicate my laptop to automated testing, but I do raise a fuss when it fails.

A build farm would help, especially with simple portability errors like this. Would be good to get OS X, Solaris (our old nemesis), and a few variations for /bin/sh. But I don't really have a good machine to volunteer for the effort myself.

~~ Brian G.