[PATCH v2 22/49] builtin/repack.c: pass "packtmp" to `generated_pack_populate()`
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Oct 15, 2025, 22:28 UTC
- Message-ID
- <acd9a83ed035ff0bec330363506acc30ef669672.1760567210.git.me@ttaylorr.com>
- In-Reply-To
- <cover.1760567210.git.me@ttaylorr.com>
In a similar spirit as previous commits, this function needs to know the temporary pack prefix, which it currently accesses through the static "packtmp" variable within builtin/repack.c.
Pass it explicitly as a function parameter to facilitate moving this function out of builtin/repack.c entirely.
Signed-off-by: Taylor Blau <me@ttaylorr.com> --- builtin/repack.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/builtin/repack.c b/builtin/repack.c index bf413a6ee2..bed902adde 100644 --- a/builtin/repack.c +++ b/builtin/repack.c @@ -150,7 +150,8 @@ struct generated_pack { struct tempfile *tempfiles[ARRAY_SIZE(exts)]; }; -static struct generated_pack *generated_pack_populate(const char *name) +static struct generated_pack *generated_pack_populate(const char *name, + const char *packtmp) { struct stat statbuf; struct strbuf path = STRBUF_INIT; @@ -271,7 +272,7 @@ static void repack_promisor_objects(struct repository *repo, line.buf); write_promisor_file(promisor_name, NULL, 0); - item->util = generated_pack_populate(item->string); + item->util = generated_pack_populate(item->string, packtmp); free(promisor_name); } @@ -896,7 +897,7 @@ static int finish_pack_objects_cmd(const struct git_hash_algo *algop, */ if (local) { item = string_list_append(names, line.buf); - item->util = generated_pack_populate(line.buf); + item->util = generated_pack_populate(line.buf, packtmp); } } fclose(out);
-- 2.51.0.540.ga7423965ad8