Re: [PATCH 40/49] builtin/repack.c: introduce `struct write_pack_opts`

From: Taylor Blau <me@ttaylorr.com>
Date: Oct 10, 2025, 23:13 UTC
Message-ID: <aOmTE0H+22KmHm1O@nand.local>
In-Reply-To: <aOj75uPA6cFW9WhN@pks.im>

On Fri, Oct 10, 2025 at 02:28:22PM +0200, Patrick Steinhardt wrote:

Show 17 quoted lines

> On Sun, Sep 28, 2025 at 06:09:51PM -0400, Taylor Blau wrote:
> > diff --git a/builtin/repack.c b/builtin/repack.c
> > index 5fed79e826..6df7c88085 100644
> > --- a/builtin/repack.c
> > +++ b/builtin/repack.c
> > @@ -138,9 +138,7 @@ static int finish_pack_objects_cmd(const struct git_hash_algo *algop,
> >  	return finish_command(cmd);
> >  }
> >
> > -static int write_filtered_pack(const struct pack_objects_args *args,
> > -			       const char *destination,
> > -			       const char *pack_prefix,
> > +static int write_filtered_pack(struct write_pack_opts *opts,
> >  			       struct existing_packs *existing,
> >  			       struct string_list *names)
>
> Is there any reason why the new argument isn't marked as `const`?

None other than forgetfulness ;-).

I adjusted it locally, which makes me think that I've accumulated enough to merit sending out another round of this series. I'll plan on doing so sometime early next week once the review has settled down here.

Thanks, Taylor