Re: [PATCH 41/49] builtin/repack.c: use `write_pack_opts` within `write_cruft_pack()`

From: Taylor Blau <me@ttaylorr.com>
Date: Oct 10, 2025, 23:13 UTC
Message-ID: <aOmTNbqC6Pz0B8SL@nand.local>
In-Reply-To: <aOj79rYGyYWYUGGY@pks.im>

On Fri, Oct 10, 2025 at 02:28:38PM +0200, Patrick Steinhardt wrote:

Show 19 quoted lines

> On Sun, Sep 28, 2025 at 06:09:57PM -0400, Taylor Blau wrote:
> > diff --git a/builtin/repack.c b/builtin/repack.c
> > index 6df7c88085..501359c580 100644
> > --- a/builtin/repack.c
> > +++ b/builtin/repack.c
> > @@ -221,9 +221,7 @@ static void combine_small_cruft_packs(FILE *in, size_t combine_cruft_below_size,
> >  	strbuf_release(&buf);
> >  }
> >
> > -static int write_cruft_pack(const struct pack_objects_args *args,
> > -			    const char *destination,
> > -			    const char *pack_prefix,
> > +static int write_cruft_pack(struct write_pack_opts *opts,
> >  			    const char *cruft_expiration,
> >  			    unsigned long combine_cruft_below_size,
> >  			    struct string_list *names,
>
> Same question here regarding the constness. Subsequent patches also
> surface this question.

Yeah, there ended up being a little bit of fallout/churn after marking it as const earlier, but those are all fixed up in my local version of these later patches.

Thanks, Taylor