Re: [PATCH 17/49] builtin/repack.c: pass "packdir" when removing packs

From: Patrick Steinhardt <ps@pks.im>
Date: Sep 29, 2025, 23:21 UTC
Message-ID: <aNsUfrE-2Wc8_1Fm@pks.im>
In-Reply-To: <df75c3130bced8d5489dc9184701a0a544617049.1759097191.git.me@ttaylorr.com>

On Sun, Sep 28, 2025 at 06:08:16PM -0400, Taylor Blau wrote:

Show 8 quoted lines

> builtin/repack.c defines a static "packdir" to instruct pack-objects on
> where to write any new packfiles. This is also the directory scanned
> when removing any packfiles which were made redundant by the latest
> repack.
> 
> Prepare to move the "existing_packs_remove_redundant" function to its
> own compilation unit by passing in this information as a parameter to
> that function.

I would have expected that we also get rid of that static variable either in this commit or a follow-up. Is there any reason why you skipped over this? If so, it would be great to highlight in the commit message.

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.