Re: [PATCH v4 2/2] launch_editor(): indicate that Git waits for user input

From: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Date: Dec 2, 2017, 03:45 UTC
Message-ID: <aacb7604-edc3-a920-da43-701b57045956@gmail.com>
In-Reply-To: <20171201182924.GB27688@sigill.intra.peff.net>

On Friday 01 December 2017 11:59 PM, Jeff King wrote:

Show 13 quoted lines

> On Fri, Dec 01, 2017 at 01:52:14PM +0100, Lars Schneider wrote:
>>
>> Thanks for the review :-)
> 
> Actually, I meant to bikeshed one part but forgot. ;)
> 
>> +                       fprintf(stderr, _("hint: Waiting for your editor input..."));
> 
> I found "waiting for editor input" to be a funny way of saying this. I
> input to the editor, the editor does not input to Git. :)
> 
> Maybe "waiting for your editor finish" or something would make more
> sense?

May be the good "Launched editor. Waiting ..." message, that was used in a previous version, itself makes sense?

> 
> Or given that the goal is really just making it clear that we've spawned
> an editor, something like "starting editor %s..." would work.

There was already discussion related to the "continuous tense" used in the phrase.

Extract from [1]:

-- 8< --
 >                 fprintf(stderr, "Launching your editor...");

"It takes quite some time to launch this special Git Editor"

As Lars pointed out, the editor may be launched in the background, that the user would not know, but they might expect a thing to pop up as a modal dialog as is always with UIs.

So despite it being technically wrong at this point in time, I would phrase it in past tense or in a way that indicates that the user needs to take action already.

The "Launching..." sounds as if I need to wait for an event to occur. -- >8 --

[1]: https://public-inbox.org/git/CAGZ79kZbm8SGY4rXKZHV82E-HX9qbQ4iyCbMgJEBFQf4fj3u=Q@mail.gmail.com/

> I think
> the "waiting for..." pattern is perfectly fine, though.
>