Re: [PATCH v4 2/2] launch_editor(): indicate that Git waits for user input

From: Jeff King <peff@peff.net>
Date: Dec 4, 2017, 22:09 UTC
Message-ID: <20171204220908.GA8184@sigill.intra.peff.net>
In-Reply-To: <787AD800-7169-4B83-A1AD-171A15D103B9@gmail.com>

On Mon, Dec 04, 2017 at 10:54:40PM +0100, Lars Schneider wrote:

Show 18 quoted lines

> > Better, IMHO, though I still think literally saying:
> > 
> >  hint: Waiting for your editor to exit...
> > 
> > is the most accurate, which I think makes it clear that you must _exit_
> > your editor, not just save and close the file.
> 
> I think "exit" would be confusing because most graphical editors (Sublime,
> Textmate, Notepad++, ...) can open multiple files and do not need to exit. 
> The requirement is indeed save and close the file.
> 
> How about:
> 
>     hint: Waiting for your editor to close the file...
> 
> I generally like that as this is technical correct from all angles.
> My only nit would be that "the file" is a bit imprecise... but
> that's probably no problem.

OK, that makes sense. There are two definitions of "exit" here. We care about the process exiting, but of course the editor may present a concept of "exiting" to the user that is different.

I know emacsclient behaves that way (the client process exits when the buffer is closed, even though the rest of emacs may still be running), but I didn't realize other editors did so. I know atom doesn't, but then it also exits immediately, making it inappropriate for $GIT_EDITOR in the first place.

-Peff