Re: [PATCH v4 2/2] launch_editor(): indicate that Git waits for user input

From: Jeff King <peff@peff.net>
Date: Dec 4, 2017, 17:26 UTC
Message-ID: <20171204172623.GD13332@sigill.intra.peff.net>
In-Reply-To: <D330CEDD-7F6B-49DB-A30E-EE0BDB80E28A@gmail.com>

On Sun, Dec 03, 2017 at 05:39:10PM +0100, Lars Schneider wrote:

Show 16 quoted lines

> >>> +                       fprintf(stderr, _("hint: Waiting for your editor input..."));
> >> I found "waiting for editor input" to be a funny way of saying this. I
> >> input to the editor, the editor does not input to Git. :)
> >> Maybe "waiting for your editor finish" or something would make more
> >> sense?
> > 
> > May be the good "Launched editor. Waiting ..." message, that was used in a previous version, itself makes sense?
> 
> Perfect bikeshed topic :-)
> 
> I would like to add "for your input" or "for you" to convey 
> that Git is not waiting for the machine but for the user.
> 
>     "hint: Launched editor. Waiting for your input..."
> 
> Would that work for you?

I guess "input" was the part that I found funny/confusing. The only thing we know is that we're waiting on the editor process to finish, and everything else is making assumptions about what's happening in the editor.

-Peff