Re: [PATCH v4 2/2] launch_editor(): indicate that Git waits for user input
- From
Lars Schneider <larsxschneider@gmail.com>
- Date
- Dec 4, 2017, 21:31 UTC
- Message-ID
- <07CF6EAE-815E-4846-887D-560F2459E69D@gmail.com>
- In-Reply-To
- <20171204172623.GD13332@sigill.intra.peff.net>
Show 25 quoted lines
> On 04 Dec 2017, at 18:26, Jeff King <peff@peff.net> wrote:
>
> On Sun, Dec 03, 2017 at 05:39:10PM +0100, Lars Schneider wrote:
>
>>>>> + fprintf(stderr, _("hint: Waiting for your editor input..."));
>>>> I found "waiting for editor input" to be a funny way of saying this. I
>>>> input to the editor, the editor does not input to Git. :)
>>>> Maybe "waiting for your editor finish" or something would make more
>>>> sense?
>>>
>>> May be the good "Launched editor. Waiting ..." message, that was used in a previous version, itself makes sense?
>>
>> Perfect bikeshed topic :-)
>>
>> I would like to add "for your input" or "for you" to convey
>> that Git is not waiting for the machine but for the user.
>>
>> "hint: Launched editor. Waiting for your input..."
>>
>> Would that work for you?
>
> I guess "input" was the part that I found funny/confusing. The only
> thing we know is that we're waiting on the editor process to finish, and
> everything else is making assumptions about what's happening in the
> editor.I see. How about:
"hint: Launched editor. Waiting for your action..." (my preference)
or
"hint: Launched editor. Waiting for you..."
- Lars