Re: [PATCH v4 0/2] launch_editor(): indicate that Git waits for user input
- From
Thomas Adam <thomas@xteddy.org>
- Date
- Nov 29, 2017, 18:35 UTC
- Message-ID
- <20171129183514.wze5trxjfgqxqs7z@laptop.local>
- In-Reply-To
- <20171129143752.60553-1-lars.schneider@autodesk.com>
On Wed, Nov 29, 2017 at 03:37:50PM +0100, lars.schneider@autodesk.com wrote:
> + if (print_waiting_for_editor) {
> + fprintf(stderr, _("hint: Waiting for your editor input..."));
> fflush(stderr);Just FYI, stderr is typically unbuffered on most systems I've used, and although the call to fflush() is harmless, I suspect it's not having any effect. That said, there's plenty of other places in Git which seems to think fflush()ing stderr actually does something.
-- Thomas Adam