Re: [PATCH v4 2/2] launch_editor(): indicate that Git waits for user input

From: Lars Schneider <larsxschneider@gmail.com>
Date: Dec 4, 2017, 21:54 UTC
Message-ID: <787AD800-7169-4B83-A1AD-171A15D103B9@gmail.com>
In-Reply-To: <20171204214221.GB21552@sigill.intra.peff.net>

Show 31 quoted lines

> On 04 Dec 2017, at 22:42, Jeff King <peff@peff.net> wrote:
> 
> On Mon, Dec 04, 2017 at 10:31:15PM +0100, Lars Schneider wrote:
> 
>>>> I would like to add "for your input" or "for you" to convey 
>>>> that Git is not waiting for the machine but for the user.
>>>> 
>>>>   "hint: Launched editor. Waiting for your input..."
>>>> 
>>>> Would that work for you?
>>> 
>>> I guess "input" was the part that I found funny/confusing. The only
>>> thing we know is that we're waiting on the editor process to finish, and
>>> everything else is making assumptions about what's happening in the
>>> editor.
>> 
>> I see. How about:
>> 
>> "hint: Launched editor. Waiting for your action..."
>> (my preference)
>> 
>> or
>> 
>> "hint: Launched editor. Waiting for you..."
> 
> Better, IMHO, though I still think literally saying:
> 
>  hint: Waiting for your editor to exit...
> 
> is the most accurate, which I think makes it clear that you must _exit_
> your editor, not just save and close the file.

I think "exit" would be confusing because most graphical editors (Sublime, Textmate, Notepad++, ...) can open multiple files and do not need to exit. The requirement is indeed save and close the file.

How about:

    hint: Waiting for your editor to close the file...

I generally like that as this is technical correct from all angles. My only nit would be that "the file" is a bit imprecise... but that's probably no problem.

- Lars