Re: [PATCH v4 2/2] launch_editor(): indicate that Git waits for user input

From: Lars Schneider <larsxschneider@gmail.com>
Date: Dec 3, 2017, 16:39 UTC
Message-ID: <D330CEDD-7F6B-49DB-A30E-EE0BDB80E28A@gmail.com>
In-Reply-To: <aacb7604-edc3-a920-da43-701b57045956@gmail.com>

Show 14 quoted lines

> On 02 Dec 2017, at 04:45, Kaartic Sivaraam <kaartic.sivaraam@gmail.com> wrote:
> 
> On Friday 01 December 2017 11:59 PM, Jeff King wrote:
>> On Fri, Dec 01, 2017 at 01:52:14PM +0100, Lars Schneider wrote:
>>> 
>>> Thanks for the review :-)
>> Actually, I meant to bikeshed one part but forgot. ;)
>>> +                       fprintf(stderr, _("hint: Waiting for your editor input..."));
>> I found "waiting for editor input" to be a funny way of saying this. I
>> input to the editor, the editor does not input to Git. :)
>> Maybe "waiting for your editor finish" or something would make more
>> sense?
> 
> May be the good "Launched editor. Waiting ..." message, that was used in a previous version, itself makes sense?

Perfect bikeshed topic :-)

I would like to add "for your input" or "for you" to convey that Git is not waiting for the machine but for the user.

    "hint: Launched editor. Waiting for your input..."

Would that work for you?

Thanks, Lars