Re: [PATCH 1/2] commit-graph: rename 'num_extra_edges' variable to 'num_large_edges'

From: Derrick Stolee <stolee@gmail.com>
Date: Nov 21, 2018, 11:32 UTC
Message-ID: <a82a2bec-07f5-ccd2-85ab-b9efd406929e@gmail.com>
In-Reply-To: <xmqqwop785wh.fsf@gitster-ct.c.googlers.com>

On 11/20/2018 10:29 PM, Junio C Hamano wrote:

Show 9 quoted lines

> SZEDER Gábor <szeder.dev@gmail.com> writes:
>
>> I rename these variables to 'num_large_edges', because the commit
>> graph file format speaks about the 'Large Edge List' chunk.
>>
>> However, I do find that the term 'extra' makes much more sense
>>
>> Would it make sense to do the rename in the other direction?
> I tend to agree that "large edge" is a misnomer.

I agree with you both. "Extra" is better.

Thanks,

-Stolee

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.