Re: [PATCH 2/2] commit-graph: don't call write_graph_chunk_large_edges() unnecessarily

From: Derrick Stolee <stolee@gmail.com>
Date: Nov 21, 2018, 11:33 UTC
Message-ID: <6d9ce874-0d96-1312-5b9f-71a8db20ce9b@gmail.com>
In-Reply-To: <20181121012600.26951-1-szeder.dev@gmail.com>

On 11/20/2018 8:26 PM, SZEDER Gábor wrote:

>   	write_graph_chunk_data(f, GRAPH_OID_LEN, commits.list, commits.nr);
> -	write_graph_chunk_large_edges(f, commits.list, commits.nr);
> +	if (num_large_edges)
> +		write_graph_chunk_large_edges(f, commits.list, commits.nr);

This is clearly correct, and the tests in t5318-commit-graph.sh would catch a dropped (or additional) large/extra edge chunk.

Thanks,

-Stolee

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.