Re: [PATCH v2 2/2] commit-graph: don't call write_graph_chunk_large_edges() unnecessarily

From

MÅMartin Ågren <martin.agren@gmail.com>

Date

Jan 19, 2019, 09:32 UTC

Message-ID

<CAN0heSrAHGU0OE97XyVVajbNcA+Ed=gRr-3+opF7OPg6_FiBLg@mail.gmail.com>

In-Reply-To

<20190118170549.30403-3-szeder.dev@gmail.com>

On Fri, 18 Jan 2019 at 18:23, SZEDER Gábor <szeder.dev@gmail.com> wrote:

> write_commit_graph() unconditionally invokes
> write_graph_chunk_large_edges(), even when it was decided earlier that
> that chunk won't be written.  Strictly speaking there is no bug here,
> because write_graph_chunk_large_edges() won't write anything if it

> Don't call write_graph_chunk_large_edges() when that chunk won't be
> written to spare an unnecessary iteration over all commits.

> -       write_graph_chunk_extra_edges(f, commits.list, commits.nr);
> +       if (num_extra_edges)
> +               write_graph_chunk_extra_edges(f, commits.list, commits.nr);

Martin