Re: [PATCH 1/2] commit-graph write: add progress output

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Sep 7, 2018, 12:40 UTC
Message-ID: <87h8j1qy59.fsf@evledraar.gmail.com>
In-Reply-To: <20180904202729.13900-2-avarab@gmail.com>

On Tue, Sep 04 2018, Ævar Arnfjörð Bjarmason wrote:

Show 5 quoted lines

> Before this change the "commit-graph write" command didn't report any
> progress. On my machine this command takes more than 10 seconds to
> write the graph for linux.git, and around 1m30s on the
> 2015-04-03-1M-git.git[1] test repository, which is a test case for
> larger monorepos.

There's a fun issue with this code that I'll fix, but thought was informative to send a mail about.

Because the graph verification happens in the main "git gc" process, as opposed to everything else via external commands, so all this progress output gets written to .git/gc.log.

Then next time we do a "gc --auto" we vomit out a couple of KB of progress bar output at the user, since spot that the gc.log isn't empty.