Re: [PATCH] commit-graph write: use pack order when finding commits

From: Derrick Stolee <stolee@gmail.com>
Date: Jan 17, 2019, 16:35 UTC
Message-ID: <f71fa868-25e8-a9c9-46a6-611b987f1a8f@gmail.com>
In-Reply-To: <5b1146a1-9ec6-f30e-80e9-cb7cd4dc1a58@gmail.com>

On 1/17/2019 10:09 AM, Derrick Stolee wrote:

>
> The code itself looks good, I just need to double-check the 
> performance numbers.

I tested this patch on our VFS-specific version using five "prefetch packs".

Before: 22.61 s (avg)
After: 22.18 s (avg)

Improvement: 2%

The error rate among the samples is very low (~.15 s) so this result is significant.

Considering that we are writing 4.4 million commits -- many more than the objects in the packs that we are reading -- this is an excellent improvement!

Thanks! -Stolee

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.