Re: [PATCH v3 1/2] commit-graph write: add progress output

From: Derrick Stolee <stolee@gmail.com>
Date: Oct 12, 2018, 15:12 UTC
Message-ID: <f7a0cbee-863c-61d3-4959-5cec8b43c705@gmail.com>
In-Reply-To: <877eindx03.fsf@evledraar.gmail.com>

On 10/12/2018 11:07 AM, Ævar Arnfjörð Bjarmason wrote:

Show 11 quoted lines

> On Fri, Oct 12 2018, Junio C Hamano wrote:
>
>> Makes sense. If this second iteration were also time consuming,
>> then it probably is a good idea to split these into two separate
>> phases?  "Counting 1...N" followed by "Inspecting 1...N" or
>> something like that.  Of course, if the latter does not take much
>> time, then doing without any progress indicator is also fine.
> That's a good point. Derrick: If the three loops in close_reachable()
> had to be split up into different progress stages and given different
> names what do you think they should be? Now it's "Annotating commits in
> commit graph" for all of them.

The following is the best I can think of right now:

1. Loading known commits.
2. Expanding reachable commits.
3. Clearing commit marks.

-Stolee