Re: [PATCH 02/20] packfile: pass down repository to `unuse_one_window`
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Oct 21, 2024, 21:08 UTC
- Message-ID
- <ZxbCx0xQrmaNeudE@nand.local>
- In-Reply-To
- <7ab2d08f354017ae20cc26c7078b7a38a7ab0ca5.1729504641.git.karthik.188@gmail.com>
On Mon, Oct 21, 2024 at 11:57:45AM +0200, Karthik Nayak wrote:
Show 13 quoted lines
> The function `unuse_one_window` currently relies on the global variable > `the_repository`. To eliminate global variable usage in `packfile.c`, we > should progressively shift the dependency on the_repository to higher > layers. Let's remove its usage from this function and any related ones. > > Signed-off-by: Karthik Nayak <karthik.188@gmail.com> > --- > builtin/pack-objects.c | 12 ++++++------ > pack-check.c | 6 +++--- > packfile.c | 25 +++++++++++++------------ > packfile.h | 3 ++- > streaming.c | 2 +- > 5 files changed, 25 insertions(+), 23 deletions(-)
All looks correct, as unuse_one_window() already uses the_repository, so I don't think any behavior is changed here...
Thanks, Taylor