Re: [PATCH v9 01/10] packfile: add repository to struct `packed_git`

From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Nov 27, 2024, 09:24 UTC
Message-ID: <9ca6bb8a-6597-400f-860f-3546296c441d@app.fastmail.com>
In-Reply-To: <d1fdd6996a6ee94534905fd993f3472ad318611d.1732618495.git.karthik.188@gmail.com>

On Tue, Nov 26, 2024, at 11:57, Karthik Nayak wrote:

> We do need to consider that a pack file could be part of the alternates
> of a repository, but considering that we only have one repository struct
> and also that we currently anyways use 'the_repository'. We should be
> OK with this change.

The “but considering” needs for a conclusion to come in the same sentence. But it seems that the conclusion has been put off to the next sentence: “We should be OK with this change”. That doesn’t read right to me.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.