Re: [PATCH v7 1/9] packfile: add repository to struct `packed_git`
- From
karthik nayak <karthik.188@gmail.com>
- Date
- Nov 14, 2024, 10:04 UTC
- Message-ID
- <CAOLa=ZQu3_r=F2XCaoEiB66=JmTYiYTTSswXS6SWtbnA2EEOjw@mail.gmail.com>
- In-Reply-To
- <xmqqh68a8z83.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 14 quoted lines
> karthik nayak <karthik.188@gmail.com> writes: > >> Indeed. I'll add it in locally but will avoid a re-roll just for the >> typo. > > FWIW, I'd _strongly_ prefer people *not* phrase it that way. > > It is very much sensible to refrain sending an another reroll > immediately only to correct a small typo. IOW, "avoid a" -> "avoid > an immediate" would be very much appreciated. > > But in the end, the final version should not waste all the work that > went into reviewing the series. >
Thanks for pointing it out, I agree and didn't really consider how that seems. I will be more mindful!
> Thanks.