Re: [PATCH v4 0/9] packfile: avoid using the 'the_repository' global variable

From: Jeff King <peff@peff.net>
Date: Nov 4, 2024, 17:27 UTC
Message-ID: <20241104172722.GA2989472@coredump.intra.peff.net>
In-Reply-To: <CAOLa=ZT8dvpvJ75Oe_PV4_osi7rw3EJnH2SSzUVame-eQvOruA@mail.gmail.com>

On Mon, Nov 04, 2024 at 01:39:31AM -0800, karthik nayak wrote:

Show 9 quoted lines

> >   2. I can imagine you might have used "unsigned long" because they are
> >      parsed with git_config_ulong(). That is OK on Linux, where size_t
> >      and "unsigned long" are the same size (either 32- or 64-bits). But
> >      on Windows I think it means that you cannot configure a window
> >      larger than 4GB on a 64-bit system. Or ironically you cannot set a
> >      total limit larger than 4GB, even though the default is 32TB. ;)
> 
> Yup that's the reason I changed them. TIL about size_t and how it works.
> Thanks, I'll change the types accordingly and push a new version soon.

Thanks. I think I got so busy talking about the issue that I forgot to mention why I think this is potential #leftoverbits: we probably ought to be parsing that config with git_config_ssize_t() or similar. But that is outside the scope of your series.

-Peff