Re: [PATCH 01/20] packfile: pass down repository to `odb_pack_name`
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Oct 21, 2024, 21:06 UTC
- Message-ID
- <ZxbCWvFo8ZdwPgJd@nand.local>
- In-Reply-To
- <c8cc21c2eeb9d1e0bc261143e642eff38fe33888.1729504641.git.karthik.188@gmail.com>
On Mon, Oct 21, 2024 at 11:57:44AM +0200, Karthik Nayak wrote:
Show 13 quoted lines
> diff --git a/builtin/pack-redundant.c b/builtin/pack-redundant.c
> index 5809613002..60f806e672 100644
> --- a/builtin/pack-redundant.c
> +++ b/builtin/pack-redundant.c
> @@ -688,7 +688,7 @@ int cmd_pack_redundant(int argc, const char **argv, const char *prefix UNUSED, s
> pl = red = pack_list_difference(local_packs, min);
> while (pl) {
> printf("%s\n%s\n",
> - sha1_pack_index_name(pl->pack->hash),
> + sha1_pack_index_name(the_repository, pl->pack->hash),
> pl->pack->pack_name);
> pl = pl->next;
> }I am a little surprised to see sha1_pack_index_name() converted similarly here, as this patch promises only to touch the 'odb_pack_name()' function.
> diff --git a/packfile.h b/packfile.h > index 0f78658229..507ac602b5 100644 > --- a/packfile.h > +++ b/packfile.h
Indeed, it looks like odb_pack_name(), sha1_pack_name(), sha1_pack_index_name(), parse_pack_index(), and has_pack_index() are all modified. Were these meant to go in separate patches?
Thanks, Taylor