Re: [PATCH v9 01/10] packfile: add repository to struct `packed_git`

From: karthik nayak <karthik.188@gmail.com>
Date: Nov 27, 2024, 12:15 UTC
Message-ID: <CAOLa=ZTb_nqj1ppyuZy44xKxuyTMCSO4nxJ5ohPanNCzK6xLXw@mail.gmail.com>
In-Reply-To: <9ca6bb8a-6597-400f-860f-3546296c441d@app.fastmail.com>

"Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:

Show 10 quoted lines

> On Tue, Nov 26, 2024, at 11:57, Karthik Nayak wrote:
>> We do need to consider that a pack file could be part of the alternates
>> of a repository, but considering that we only have one repository struct
>> and also that we currently anyways use 'the_repository'. We should be
>> OK with this change.
>
> The “but considering” needs for a conclusion to come in the same
> sentence.  But it seems that the conclusion has been put off to the next
> sentence: “We should be OK with this change”.  That doesn’t read right
> to me.

Hmm, yeah, perhaps a comma right after the 'the_repository' instead of a period would make it better.