Re: [PATCH v10 00/10] packfile: avoid using the 'the_repository' global variable
On Tue, Dec 3, 2024, at 15:43, Karthik Nayak wrote:
Show 33 quoted lines
> Range-diff against v9:
> 1: d1fdd6996a ! 1: d6d571c58e packfile: add repository to struct
> `packed_git`
> @@ Commit message
> on the global `the_repository` object in `packfile.c` by
> simply using
> repository information now readily available in the struct.
>
> - We do need to consider that a pack file could be part of the
> alternates
> + We do need to consider that a packfile could be part of the
> alternates
> of a repository, but considering that we only have one
> repository struct
> - and also that we currently anyways use 'the_repository'. We
> should be
> + and also that we currently anyways use 'the_repository', we
> should be
> OK with this change.
>
> We also modify `alloc_packed_git` to ensure that the
> repository is added
> 2: 65c09858ce = 2: fa69763468 packfile: use `repository` from
> `packed_git` directly
> 3: 80632934d1 ! 3: c6acbece46 packfile: pass `repository` to static
> function in the file
> @@ Commit message
> packfile: pass `repository` to static function in the file
>
> Some of the static functions in the `packfile.c` access global
> - variables, which can simply be avoiding by passing the `repository`
> + variables, which can simply be avoided by passing the `repository`
> struct down to them. Let's do that.