Re: [PATCH 00/23] Memory leak fixes (pt.3)

From: Taylor Blau <me@ttaylorr.com>
Date: Jul 31, 2024, 17:01 UTC
Message-ID: <Zqpt0/6zBOpYh4aj@nand.local>
In-Reply-To: <cover.1721995576.git.ps@pks.im>

On Fri, Jul 26, 2024 at 02:13:43PM +0200, Patrick Steinhardt wrote:

>  57 files changed, 251 insertions(+), 73 deletions(-)

I took a careful read through these patches, and found most of them easy to review. I was admittedly a little lost with the "fix various leak" patches, and having slightly more context in the commit descriptions there would have been helpful.

I think most of these patches look all good to me, but there is one where I think using a strvec would be a better fit than allocating our own array.

Otherwise, these are looking in good shape. Thanks for working on this!

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.