Re: [PATCH 02/23] builtin/log: fix leaking branch name when creating cover letters

From: Karthik Nayak <karthik.188@gmail.com>
Date: Jul 30, 2024, 09:14 UTC
Message-ID: <CAOLa=ZQ1zGe421HFqH4wCSMwc53H5eUr18j18yM0pNgD8DxR5g@mail.gmail.com>
In-Reply-To: <4daae88877f2355d6a3960883e7b3f15cf738cb5.1721995576.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> When calling `make_cover_letter()` without a branch name, then we try to

Nit: s/then//

> derive the branch name by calling `find_branch_name()`. But while this
> function returns an allocated string, we never free the result and thus
> have a memory leak. Fix this.

[snip]

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.