Re: [PATCH 03/23] builtin/describe: fix memory leak with `--contains=`

From: Taylor Blau <me@ttaylorr.com>
Date: Jul 31, 2024, 16:28 UTC
Message-ID: <ZqpmLsX8pug6qj3f@nand.local>
In-Reply-To: <08a12be13c2fed247d6086967e7a3f03fa6519e1.1721995576.git.ps@pks.im>

On Fri, Jul 26, 2024 at 02:14:18PM +0200, Patrick Steinhardt wrote:

Show 8 quoted lines

> @@ -637,7 +639,21 @@ int cmd_describe(int argc, const char **argv, const char *prefix)
>  			strvec_pushv(&args, argv);
>  		else
>  			strvec_push(&args, "HEAD");
> -		return cmd_name_rev(args.nr, args.v, prefix);
> +
> +		/*
> +		 * `cmd_name_rev()` modifies the array, so we'd link its

s/link/leak/ ?

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.