[PATCH v2 05/24] builtin/describe: fix trivial memory leak when describing blob
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Aug 1, 2024, 10:38 UTC
- Message-ID
- <6deacb8667bfe94cdb5995302490b977b7fd2e8a.1722499961.git.ps@pks.im>
- In-Reply-To
- <cover.1722499961.git.ps@pks.im>
We never free the `struct strvec args` variable in `describe_blob()`, which thus causes a memory leak. Fix this.
Signed-off-by: Patrick Steinhardt <ps@pks.im> --- builtin/describe.c | 1 + t/t9903-bash-prompt.sh | 1 + 2 files changed, 2 insertions(+)
diff --git a/builtin/describe.c b/builtin/describe.c index 2957ff7031..954929c514 100644 --- a/builtin/describe.c +++ b/builtin/describe.c @@ -529,6 +529,7 @@ static void describe_blob(struct object_id oid, struct strbuf *dst) traverse_commit_list(&revs, process_commit, process_object, &pcd); reset_revision_walk(); release_revisions(&revs); + strvec_clear(&args); } static void describe(const char *arg, int last_one) diff --git a/t/t9903-bash-prompt.sh b/t/t9903-bash-prompt.sh index d667dda654..95e9955bca 100755 --- a/t/t9903-bash-prompt.sh +++ b/t/t9903-bash-prompt.sh @@ -8,6 +8,7 @@ test_description='test git-specific bash prompt functions' GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME +TEST_PASSES_SANITIZE_LEAK=true . ./lib-bash.sh . "$GIT_BUILD_DIR/contrib/completion/git-prompt.sh"
-- 2.46.0.dirty