From: Taylor Blau Date: Wed, 31 Jul 2024 17:01:07 GMT Subject: Re: [PATCH 00/23] Memory leak fixes (pt.3) Message-ID: In-Reply-To: On Fri, Jul 26, 2024 at 02:13:43PM +0200, Patrick Steinhardt wrote: > 57 files changed, 251 insertions(+), 73 deletions(-) I took a careful read through these patches, and found most of them easy to review. I was admittedly a little lost with the "fix various leak" patches, and having slightly more context in the commit descriptions there would have been helpful. I think most of these patches look all good to me, but there is one where I think using a strvec would be a better fit than allocating our own array. Otherwise, these are looking in good shape. Thanks for working on this! Thanks, Taylor