[PATCH 23/23] commit-reach: fix trivial memory leak when computing reachability
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Jul 26, 2024, 12:19 UTC
- Message-ID
- <60aef16aef5e5733d449b3e9fd1a8816b5d82c27.1721995576.git.ps@pks.im>
- In-Reply-To
- <cover.1721995576.git.ps@pks.im>
We don't free the local `stack` commit list that we use to compute reachability of multiple commits at once. Do so.
Signed-off-by: Patrick Steinhardt <ps@pks.im> --- commit-reach.c | 1 + t/t3201-branch-contains.sh | 1 + 2 files changed, 2 insertions(+)
diff --git a/commit-reach.c b/commit-reach.c index dabc2972e4..02f8218b8e 100644 --- a/commit-reach.c +++ b/commit-reach.c @@ -1227,4 +1227,5 @@ void tips_reachable_from_bases(struct repository *r, done: free(commits); repo_clear_commit_marks(r, SEEN); + free_commit_list(stack); } diff --git a/t/t3201-branch-contains.sh b/t/t3201-branch-contains.sh index 800fc33165..6e587d27d7 100755 --- a/t/t3201-branch-contains.sh +++ b/t/t3201-branch-contains.sh @@ -2,6 +2,7 @@ test_description='branch --contains <commit>, --no-contains <commit> --merged, and --no-merged' +TEST_PASSES_SANITIZE_LEAK=true . ./test-lib.sh test_expect_success setup '
-- 2.46.0.rc1.dirty