Re: [PATCH 03/23] builtin/describe: fix memory leak with `--contains=`

From: Patrick Steinhardt <ps@pks.im>
Date: Jul 31, 2024, 10:42 UTC
Message-ID: <ZqoVDkOw5IEWv52m@tanuki>
In-Reply-To: <xmqqr0bagark.fsf@gitster.g>

On Tue, Jul 30, 2024 at 08:27:59AM -0700, Junio C Hamano wrote:

Show 8 quoted lines

> Patrick Steinhardt <ps@pks.im> writes:
> [Footnote]
> 
>  * The fact that cmd_foo() is called is not a hygiene thing to do in
>    the first place, and in the longer term #leftoverbits we may need
>    to refactor the thing further, into a proper library-ish reusable
>    helper function that can be used to compute name_rev() any number
>    of times, plus cmd_name_rev() and this caller that call it.

Agreed. There have been several instances of this scattered across the codebase. The fix is quite ugly in my opinion, but it would be a bigger topic to refactor those cases properly, so I refrained from doing so as part of this series.

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.