From: Taylor Blau <me@ttaylorr.com>
Date: Wed, 31 Jul 2024 16:28:30 GMT
Subject: Re: [PATCH 03/23] builtin/describe: fix memory leak with `--contains=`
Message-ID: <ZqpmLsX8pug6qj3f@nand.local>
In-Reply-To: <08a12be13c2fed247d6086967e7a3f03fa6519e1.1721995576.git.ps@pks.im>

On Fri, Jul 26, 2024 at 02:14:18PM +0200, Patrick Steinhardt wrote:
> @@ -637,7 +639,21 @@ int cmd_describe(int argc, const char **argv, const char *prefix)
>  			strvec_pushv(&args, argv);
>  		else
>  			strvec_push(&args, "HEAD");
> -		return cmd_name_rev(args.nr, args.v, prefix);
> +
> +		/*
> +		 * `cmd_name_rev()` modifies the array, so we'd link its

s/link/leak/ ?

Thanks,
Taylor