Re: [PATCH v11 0/3] Enhance credential helper protocol to include auth headers

From: Jeff King <peff@peff.net>
Date: Feb 27, 2023, 20:27 UTC
Message-ID: <Y/0SNW4p0oS9RCbE@coredump.intra.peff.net>
In-Reply-To: <pull.1352.v11.git.1677518420.gitgitgadget@gmail.com>

On Mon, Feb 27, 2023 at 05:20:17PM +0000, Matthew John Cheetham via GitGitGadget wrote:

Show 8 quoted lines

> Updates in v11
> ==============
> 
>  * Delete custom-auth.valid and .challenge explicitly in test cleanup.
> 
>  * Use tolower over strncasecmp in implementation of skip_iprefix_mem.
> 
>  * Use skip_iprefix_mem to match "HTTP/" header lines.

Thanks, I looked over all three changes and the whole thing looks good to me. The first one isn't strictly necessary if we're not renaming the script, but I agree that it is probably worth being a bit more strict when deleting in $HTTPD_ROOT_PATH.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.