Re: [PATCH v7 00/12] Enhance credential helper protocol to include auth headers
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 26, 2023, 16:05 UTC
- Message-ID
- <xmqqfsbxcmdd.fsf@gitster.g>
- In-Reply-To
- <Y9JkMLueCwjkLHOr@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 10 quoted lines
>> Thanks, both. Let's merge it down. > > Sorry, I'm a bit late to the party, but I left some comments just now > (this topic had been on my review backlog for ages, but I never quite > got to it). > > Many of my comments were small bits that could be fixed on top (tiny > leaks, etc). But some of my comments were of the form "no, do it totally > differently". It may simply be too late for those ones, but let's see if > Matthew finds anything compelling in them.
I do not mind reverting the merge to 'next' to have an improved version. Your "do we really want to add a custom server based on questionable codebase whose quality as a test-bed for real world usage is dubious?" is a valid concern.