From: Jeff King <peff@peff.net>
Date: Mon, 27 Feb 2023 20:27:33 GMT
Subject: Re: [PATCH v11 0/3] Enhance credential helper protocol to include auth headers
Message-ID: <Y/0SNW4p0oS9RCbE@coredump.intra.peff.net>
In-Reply-To: <pull.1352.v11.git.1677518420.gitgitgadget@gmail.com>

On Mon, Feb 27, 2023 at 05:20:17PM +0000, Matthew John Cheetham via GitGitGadget wrote:

> Updates in v11
> ==============
> 
>  * Delete custom-auth.valid and .challenge explicitly in test cleanup.
> 
>  * Use tolower over strncasecmp in implementation of skip_iprefix_mem.
> 
>  * Use skip_iprefix_mem to match "HTTP/" header lines.

Thanks, I looked over all three changes and the whole thing looks good
to me. The first one isn't strictly necessary if we're not renaming the
script, but I agree that it is probably worth being a bit more strict
when deleting in $HTTPD_ROOT_PATH.

-Peff