Re: [PATCH v4 8/8] t5556: add HTTP authentication tests

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 15, 2022, 00:21 UTC
Message-ID: <xmqqpmcltt36.fsf@gitster.g>
In-Reply-To: <1dc44716-2550-47de-e666-9972b102905d@github.com>

Victoria Dye <vdye@github.com> writes:

Show 7 quoted lines

> A general comment about this series - the way you have the patches organized
> means that the "feature" content you're trying to integrate (the first two
> patches) is contextually separated from these tests. For people that
> learn/understand code via examples in tests, this makes it really difficult
> to understand what's going on. To avoid that, I think you could rearrange
> the patches pretty easily:
> ...

Thanks for a thorough review of the entire series, with concrete suggestions for improvements with encouragements sprinkled in.

Very much appreciated.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.