Re: [PATCH v5 10/10] credential: add WWW-Authenticate header to cred requests

From: Matthew John Cheetham <mjcheetham@outlook.com>
Date: Jan 17, 2023, 21:18 UTC
Message-ID: <AS2PR03MB9815C6A25546FD8CAD4D0CD6C0C69@AS2PR03MB9815.eurprd03.prod.outlook.com>
In-Reply-To: <98940e93-c4c5-01ec-54b2-b6015f488ad0@github.com>

On 2023-01-12 12:41, Derrick Stolee wrote:

Show 10 quoted lines

> On 1/11/2023 5:13 PM, Matthew John Cheetham via GitGitGadget wrote:
> 
>> +static void credential_write_strvec(FILE *fp, const char *key,
>> +				    const struct strvec *vec)
>> +{
>> +	int i = 0;
>> +	const char *full_key = xstrfmt("%s[]", key);
>> +	for (; i < vec->nr; i++) {
> 
> style nit: use "int i;" and "for (i = 0; ..."

Thanks for pointing this out; I missed that C99 style for-loops were allowed now. As Ævar pointed out, this should also be `size_t` and not `int`.

Show 13 quoted lines

>>  test_expect_success 'http auth anonymous no challenge' '
>>  	test_when_finished "per_test_cleanup" &&
>> -	start_http_server &&
>> +
>> +	cat >auth.config <<-EOF &&
>> +	[auth]
>> +	    allowAnonymous = true
>> +	EOF
>> +
>> +	start_http_server --auth-config="$TRASH_DIRECTORY/auth.config" &&
> 
> I see that you added auth.allowAnonymous and --auth-config options
> in Patch 6, so perhaps this test change could move to that patch.

Good point; will update on reroll.

> Thanks,
> -Stolee