Re: [PATCH 3/8] osxkeychain: clarify that we ignore unknown lines
- From
Matthew John Cheetham <mjcheetham@outlook.com>
- Date
- Sep 21, 2022, 22:48 UTC
- Message-ID
- <AS8PR03MB86897FAC3E1E4F03D4420644C04F9@AS8PR03MB8689.eurprd03.prod.outlook.com>
- In-Reply-To
- <ead6293c-8906-04c9-6566-e47efb624385@github.com>
On 2022-09-19 09:12, Derrick Stolee wrote:
Show 15 quoted lines
> On 9/13/2022 3:25 PM, Matthew John Cheetham via GitGitGadget wrote: >> From: Matthew John Cheetham <mjcheetham@outlook.com> >> >> Like in all the other credential helpers, the osxkeychain helper >> ignores unknown credential lines. >> >> Add a comment (a la the other helpers) to make it clear and explicit >> that this is the desired behaviour. > > I recommend that these first three patches be submitted for full > review and merging, since they seem important independent of this > RFC. > > Thanks, > -Stolee
That's a fair point. I will submit these independently.
Thanks, Matthew