Re: [PATCH v4 8/8] t5556: add HTTP authentication tests
- From
Matthew John Cheetham <mjcheetham@outlook.com>
- Date
- Jan 11, 2023, 22:05 UTC
- Message-ID
- <AS2PR03MB98153051196418108D6CCAEFC0FC9@AS2PR03MB9815.eurprd03.prod.outlook.com>
- In-Reply-To
- <xmqqpmcltt36.fsf@gitster.g>
On 2022-12-14 16:21, Junio C Hamano wrote:
Show 15 quoted lines
> Victoria Dye <vdye@github.com> writes: > >> A general comment about this series - the way you have the patches organized >> means that the "feature" content you're trying to integrate (the first two >> patches) is contextually separated from these tests. For people that >> learn/understand code via examples in tests, this makes it really difficult >> to understand what's going on. To avoid that, I think you could rearrange >> the patches pretty easily: >> ... > > Thanks for a thorough review of the entire series, with concrete > suggestions for improvements with encouragements sprinkled in. > > Very much appreciated. >
Yes! Thank you Victoria for the detailed and thorough review. I also too very much appreciate it :-)
Thanks, Matthew