Re: [PATCH 08/23] ewah: implement bitmap_or()

From: Taylor Blau <me@ttaylorr.com>
Date: Nov 23, 2020, 16:52 UTC
Message-ID: <X7vouTlBlT62H7A4@nand.local>
In-Reply-To: <xmqq3611qgg4.fsf@gitster.c.googlers.com>

On Sun, Nov 22, 2020 at 12:34:03PM -0800, Junio C Hamano wrote:

Show 14 quoted lines

> Taylor Blau <me@ttaylorr.com> writes:
>
> > From: Jeff King <peff@peff.net>
> >
> > We have a function to bitwise-OR an ewah into an uncompressed bitmap,
> > but not to OR two uncompressed bitmaps. Let's add it.
> >
> > Interestingly, we have a public header declaration going back to
> > e1273106f6 (ewah: compressed bitmap implementation, 2013-11-14), but the
> > function was never implemented.
>
> So we have had decl, no impl, but it did not matter because there
> was no user?  Presumably we will see a real user soon in the series
> ;-)

Indeed :-). I added a note to this patch's log message to indicate that a new/first caller would be appearing in a couple of patches after this one.

Thanks, Taylor