Re: [PATCH v2 00/24] pack-bitmap: bitmap generation improvements

From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Nov 18, 2020, 18:32 UTC
Message-ID: <20201118183225.GB8396@szeder.dev>
In-Reply-To: <cover.1605649533.git.me@ttaylorr.com>

On Tue, Nov 17, 2020 at 04:46:16PM -0500, Taylor Blau wrote:

>   - Harden the tests so that they pass under sha256-mode (thanks SZEDER,
>     and Peff).

Fixing this is good, of course, but...

Show 14 quoted lines

> 16:  86d77fd085 ! 18:  5262daa330 pack-bitmap-write: build fewer intermediate bitmaps
>     @@ t/t5310-pack-bitmaps.sh: test_expect_success 'setup repo with moderate-sized his
>       '
> 
>       test_expect_success 'rev-list --test-bitmap verifies bitmaps' '
>     +@@ t/t5310-pack-bitmaps.sh: test_expect_success 'truncated bitmap fails gracefully (ewah)' '
>     + 	git rev-list --use-bitmap-index --count --all >expect &&
>     + 	bitmap=$(ls .git/objects/pack/*.bitmap) &&
>     + 	test_when_finished "rm -f $bitmap" &&
>     +-	test_copy_bytes 256 <$bitmap >$bitmap.tmp &&
>     ++	test_copy_bytes 270 <$bitmap >$bitmap.tmp &&
>     + 	mv -f $bitmap.tmp $bitmap &&
>     + 	git rev-list --use-bitmap-index --count --all >actual 2>stderr &&
>     + 	test_cmp expect actual &&

Please don't simply sneak in such a change without explaining it in the commit message.