Re: [PATCH v2 15/24] t5310: add branch-based checks
- From
- Jonathan Tan <jonathantanmy@google.com>
- Date
- Nov 25, 2020, 01:17 UTC
- Message-ID
- <20201125011748.944638-1-jonathantanmy@google.com>
- In-Reply-To
- <8b5d23933301988e42ddd57687e0535f8749367f.1605649533.git.me@ttaylorr.com>
Show 5 quoted lines
> From: Derrick Stolee <dstolee@microsoft.com> > > The current rev-list tests that check the bitmap data only work on HEAD > instead of multiple branches. Expand the test cases to handle both > 'master' and 'other' branches.
[snip]
> +rev_list_tests () {
> + state=$1
> +
> + for branch in "master" "other"Would it be worth including "HEAD" in the list here? It would make more sense with the commit message saying "exstend" instead of "replace".
[snip rest]
The 2 prior patches (13 and 14) look good to me.