Re: [PATCH v2 24/24] pack-bitmap-write: better reuse bitmaps

From: Jonathan Tan <jonathantanmy@google.com>
Date: Dec 7, 2020, 18:26 UTC
Message-ID: <20201207182633.3036948-1-jonathantanmy@google.com>
In-Reply-To: <X8fcAZU30P5MdfRR@nand.local>

Show 15 quoted lines

> On Wed, Dec 02, 2020 at 01:22:27PM -0500, Derrick Stolee wrote:
> > >> We could even skip the whole maximal stuff (for commits with existing
> > >> bitmaps) and replace "c_ent->maximal = 1;" above with "add to list that
> > >> we're going to append to bb->commits at the very end". That has the
> > >> advantage of not having to redefine "maximal".
> > >
> > > Hmm. I'd trust Stolee's opinion over mine here, so I'll be curious what
> > > he has to say.
> >
> > It would be equivalent to add it to the list and then continuing the
> > loop instead of piggy-backing on the if (c_ent->maximal) block, followed
> > by a trivial loop over the (nullified) parents.
> 
> Jonathan: does that seem OK to you to leave it as-is? If you don't have
> strong objections, I'll go ahead with sending v3 a little later today.

Like I (just) said in [1], I think that my comment stands, but this is a minor and local issue that does not affect the functionality of the overall patch set so I think you can go ahead and send v3.

[1] https://lore.kernel.org/git/20201207182418.3034961-1-jonathantanmy@google.com/