Re: [PATCH v2 00/24] pack-bitmap: bitmap generation improvements

From: Taylor Blau <me@ttaylorr.com>
Date: Nov 22, 2020, 02:17 UTC
Message-ID: <X7nKRxNy47nTre3b@xnor.local>
In-Reply-To: <X7V7X/qDfN0udr2u@nand.local>

On Wed, Nov 18, 2020 at 02:51:59PM -0500, Taylor Blau wrote:

Show 8 quoted lines

> On Wed, Nov 18, 2020 at 07:32:25PM +0100, SZEDER Gábor wrote:
> > Please don't simply sneak in such a change without explaining it in
> > the commit message.
>
> Ah, I certainly didn't mean to go under the radar, so to speak ;-). From
> my perspective, the final patch looks like it picked a magic number in
> the same way was the original version of this patch did, so I didn't
> think to add any more detail there.

Oops; when I wrote that to you, I had in my mind that this patch already changed that line in the tests, so the rerolled patch was simply changing it to something different.

But, this isn't a new test from this patch's perspective, so I'll make a note of why this changed in a replacement.

Thanks.

Taylor