Re: [PATCH 3/5] parseopt: autocorrect mistyped subcommands

From: Jiamu Sun <39@barroit.sh>
Date: Mar 9, 2026, 02:11 UTC
Message-ID: <SY0P300MB0801336282FC2BB0FED45085CE79A@SY0P300MB0801.AUSP300.PROD.OUTLOOK.COM>
In-Reply-To: <xmqqo6kx98bi.fsf@gitster.g>

On Sun, Mar 08, 2026 at 05:04:49PM -0700, Junio C Hamano wrote:

Show 6 quoted lines

> > +	unsigned int min = -1;
> > +	unsigned int ties = 0;
> > +	struct string_list_item *cand;
> > +	struct string_list_item *best = NULL;
> 
> CodingGuidelines: -Wdeclaration-after-statement is here.

Will fix that to follow CodingGuidelines.

> Using "-1" as "the maximum value this unsigned type can represent"
> is somewhat misleading.  Can't we avoid that?
>

Yes, UINT_MAX is a better fit here.

-- 
Jiamu Sun <39@barroit.sh>

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.