Re: [PATCH v3 3/8] help: move tty check for autocorrection to autocorrect.c
- From
- Jiamu Sun <39@barroit.sh>
- Date
- Mar 11, 2026, 02:16 UTC
- Message-ID
- <SY0P300MB08013EBB2DC457AF040977D3CE47A@SY0P300MB0801.AUSP300.PROD.OUTLOOK.COM>
- In-Reply-To
- <CAOLa=ZS=2msGg5d-6-LgVD6XSduYze46iWcT2X_dJDd=6AOOkA@mail.gmail.com>
On Tue, Mar 10, 2026 at 07:06:17AM -0700, Karthik Nayak wrote:
Show 8 quoted lines
> > +struct autocorr {
> > + enum autocorr_mode mode;
> > + int delay;
> > +};
> > +
>
> I would say the naming doesn't indicate what it is used for. How about
> 'autocorrect_config'?Using autocorrect_config is best for semantics. The only problem is that it's too long. Since currently, this struct contains all fields needed by our autocorrect_*, using "autocorrect" to describe it is enough, perhaps?
--
Jiamu Sun <39@barroit.sh>
<sunjiamu@outlook.com>