From: Jiamu Sun <39@barroit.sh> Date: Mon, 09 Mar 2026 02:11:45 GMT Subject: Re: [PATCH 3/5] parseopt: autocorrect mistyped subcommands Message-ID: In-Reply-To: On Sun, Mar 08, 2026 at 05:04:49PM -0700, Junio C Hamano wrote: > > + unsigned int min = -1; > > + unsigned int ties = 0; > > + struct string_list_item *cand; > > + struct string_list_item *best = NULL; > > CodingGuidelines: -Wdeclaration-after-statement is here. Will fix that to follow CodingGuidelines. > Using "-1" as "the maximum value this unsigned type can represent" > is somewhat misleading. Can't we avoid that? > Yes, UINT_MAX is a better fit here. -- Jiamu Sun <39@barroit.sh>